Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

E2E finish refactoring #1593

Merged
merged 5 commits into from
Mar 30, 2023
Merged

E2E finish refactoring #1593

merged 5 commits into from
Mar 30, 2023

Conversation

unsortedhashsets
Copy link
Member

Hi,

With that PR I would like to finish E2E tests refactoring iteration:

  • All test are refactored with common function
  • All API calls waits now lays in functions that create requests (for example) (unfortunatelly interception can not be global needed to be repeated in the each Before section)
  • All lodash.times method faced in tests were replaced
  • Unlocked all tests except one: 06-undo_redo_actions/undo_redo_actions.cy.js blocked by Issue-1275

@unsortedhashsets unsortedhashsets requested a review from a team March 30, 2023 09:49
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #1593 (bb7b6b3) into main (b56087a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1593   +/-   ##
=======================================
  Coverage   57.03%   57.03%           
=======================================
  Files          69       69           
  Lines        2055     2055           
  Branches      470      470           
=======================================
  Hits         1172     1172           
  Misses        839      839           
  Partials       44       44           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
43.3% 43.3% Duplication

Copy link
Collaborator

@kahboom kahboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this locally, great work @unsortedhashsets ! The tests are a pleasure to both read and run now. 🙂

@kahboom
Copy link
Collaborator

kahboom commented Mar 30, 2023

Tiny nitpick @unsortedhashsets --try to write your main commit message in this format when you can: chore(e2e): <blah blah> or chore(test): <blah blah>, it just makes it easier for writing notes in releases, but it's not a big deal otherwise.

@kahboom kahboom merged commit 6a5a2ca into KaotoIO:main Mar 30, 2023
@unsortedhashsets
Copy link
Member Author

Tiny nitpick @unsortedhashsets --try to write your main commit message in this format when you can: chore(e2e): <blah blah> or chore(test): <blah blah>, it just makes it easier for writing notes in releases, but it's not a big deal otherwise.

Oh, sorry, skipped that comment last week!
Will do! Thanks for the advice!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants