This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
fix: yarn build:lib on CI related to OTEL deps #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
helio-frota
commented
Mar 31, 2023
helio-frota
commented
- The SimpleSpanProcessor was imported via other internal dependency, this probably was related to my vscode auto-import in the first PR or something, when adding otel capabilities.
* The SimpleSpanProcessor was imported via other internal dependency, this probably was related to my vscode auto-import in the first PR or something, when adding otel capabilities.
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #1607 +/- ##
==========================================
+ Coverage 56.98% 61.05% +4.06%
==========================================
Files 69 70 +1
Lines 2053 2054 +1
Branches 470 470
==========================================
+ Hits 1170 1254 +84
+ Misses 839 756 -83
Partials 44 44
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.