Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

fix: yarn build:lib on CI related to OTEL deps #1607

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

helio-frota
Copy link
Contributor

  • The SimpleSpanProcessor was imported via other internal dependency, this probably was related to my vscode auto-import in the first PR or something, when adding otel capabilities.

* The SimpleSpanProcessor was imported via other internal dependency,
  this probably was related to my vscode auto-import in the first PR or
  something, when adding otel capabilities.
@helio-frota helio-frota requested a review from a team March 31, 2023 18:30
@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #1607 (435b638) into main (ac1b5a7) will increase coverage by 4.06%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #1607      +/-   ##
==========================================
+ Coverage   56.98%   61.05%   +4.06%     
==========================================
  Files          69       70       +1     
  Lines        2053     2054       +1     
  Branches      470      470              
==========================================
+ Hits         1170     1254      +84     
+ Misses        839      756      -83     
  Partials       44       44              
Impacted Files Coverage Δ
src/services/stepsService.ts 33.48% <0.00%> (ø)
src/store/integrationJsonStore.tsx 91.56% <100.00%> (+67.46%) ⬆️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lordrip lordrip merged commit 8dfdfbf into KaotoIO:main Apr 3, 2023
@helio-frota helio-frota deleted the fix-otel-updates branch April 3, 2023 10:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants