Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Add stepNode__clickable class to Node #1615

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

unsortedhashsets
Copy link
Member

@unsortedhashsets unsortedhashsets commented Apr 3, 2023

Hi,

here is a small fix to the issue with not clickable node circle

Before:
clickOutsideOfIconIsNotWorking

After:
clickOutsideOfIconIsWorking

Relates:

@unsortedhashsets unsortedhashsets requested a review from a team April 3, 2023 13:02
@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
27.9% 27.9% Duplication

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #1615 (07887fb) into main (c5b9a68) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1615   +/-   ##
=======================================
  Coverage   61.05%   61.05%           
=======================================
  Files          70       70           
  Lines        2054     2054           
  Branches      470      470           
=======================================
  Hits         1254     1254           
  Misses        756      756           
  Partials       44       44           
Impacted Files Coverage Δ
src/components/VisualizationStep.tsx 62.65% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@kahboom kahboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @unsortedhashsets

@kahboom kahboom linked an issue Apr 3, 2023 that may be closed by this pull request
@kahboom
Copy link
Collaborator

kahboom commented Apr 3, 2023

fixes #1597

@kahboom kahboom merged commit 37ca3cd into KaotoIO:main Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have hover highlight in phase with selection of element
2 participants