chore: Hide Config tab if no properties exist #1658

pnaik1 · 2023-04-17T07:12:02Z

codecov · 2023-04-17T07:18:26Z

Codecov Report

Merging #1658 (a3d98ae) into main (2ae52d8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1658      +/-   ##
==========================================
+ Coverage   65.58%   65.59%   +0.01%     
==========================================
  Files          71       71              
  Lines        2057     2058       +1     
  Branches      469      470       +1     
==========================================
+ Hits         1349     1350       +1     
  Misses        666      666              
  Partials       42       42

Impacted Files	Coverage Δ
src/components/VisualizationStepViews.tsx	`69.62% <100.00%> (+0.38%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

kahboom

Tiny nitpick, otherwise this looks good. 👍

src/components/VisualizationStepViews.tsx

pnaik1 · 2023-04-17T12:17:55Z

yeah sure @kahboom , is there any way to format the particular page? . I tried using npm run format:fix , its formatting all the pages

kahboom · 2023-04-17T13:54:55Z

@pnaik1 - Thanks for making the change. Unfortunately we don't have a pre-commit hook added yet, maybe I will look at that this week. If you use VSCode, it specifically has an option to apply Prettier only to files changed: https://code.visualstudio.com/updates/v1_49#_only-format-modified-text

Btw, it looks like DeepScan is complaining because it wants you to add > 0 like this: {step.parameters?.length > 0 && !hasConfigView && (. You can see the check here. If you don't mind making that quick change I will be happy to merge this.