Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

chore(e2e): Add new wait for intercepted requests #1686

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

unsortedhashsets
Copy link
Member

I have added an additional wait for intercepting requests after opening the configuration for steps (not EIP)

In the absence of waiting, the flakiness of the test increases significantly (tested a lot with and without)

Related issue -> 1680

@unsortedhashsets unsortedhashsets added enhancement Improve existing features chore Tests, CI/CD, general maintenance labels Apr 24, 2023
@unsortedhashsets unsortedhashsets requested a review from a team April 24, 2023 11:41
@sonarcloud
Copy link

sonarcloud bot commented Apr 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.3% 3.3% Duplication

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #1686 (b670980) into main (7976f19) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1686   +/-   ##
=======================================
  Coverage   65.59%   65.59%           
=======================================
  Files          71       71           
  Lines        2058     2058           
  Branches      470      470           
=======================================
  Hits         1350     1350           
  Misses        666      666           
  Partials       42       42           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lordrip lordrip merged commit 443a36b into KaotoIO:main Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore Tests, CI/CD, general maintenance enhancement Improve existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E tests flakiness increased significantly on Firefox (3 step integration -- add the step integration)
2 participants