Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

chore(e2e): Add about modal e2e tests #1716

Merged
merged 1 commit into from
May 2, 2023

Conversation

unsortedhashsets
Copy link
Member

Hi,

A small addition to e2e: tests for about modal

  • Close and reopen about modal
  • Check that the about modal contains the correct information (logo is visible and with size more than zero, backend and frontend versions are Ok, versions grid is correct)
about.cy.js.mp4

PR resolves #1700

@unsortedhashsets unsortedhashsets requested a review from a team May 2, 2023 06:58
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.7% 2.7% Duplication

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #1716 (80d91a0) into main (ff7d24a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1716   +/-   ##
=======================================
  Coverage   66.82%   66.82%           
=======================================
  Files          72       72           
  Lines        2077     2077           
  Branches      471      471           
=======================================
  Hits         1388     1388           
  Misses        648      648           
  Partials       41       41           
Impacted Files Coverage Δ
src/components/AboutModal.tsx 100.00% <ø> (ø)

Copy link
Collaborator

@kahboom kahboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @unsortedhashsets !

@kahboom kahboom merged commit 7e0d8bb into KaotoIO:main May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[e2e] Test new About modal
2 participants