Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Fix detail panel closing behavior when deleting steps #1747

Merged
merged 1 commit into from
May 5, 2023

Conversation

mmuzikar
Copy link
Contributor

@mmuzikar mmuzikar commented May 5, 2023

Before deleting any step would deselect the currently selected step and try to close the panel. Now the panel is only closed if the currently selected step is deleted.
Closes: #1360

@mmuzikar mmuzikar requested a review from a team May 5, 2023 09:39
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #1747 (97ce262) into main (d2050dd) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1747      +/-   ##
==========================================
- Coverage   66.89%   66.85%   -0.04%     
==========================================
  Files          72       72              
  Lines        2075     2076       +1     
  Branches      470      470              
==========================================
  Hits         1388     1388              
- Misses        645      646       +1     
  Partials       42       42              
Impacted Files Coverage Δ
src/components/Visualization.tsx 64.06% <0.00%> (-1.02%) ⬇️

Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , thanks for taking it

@kahboom kahboom merged commit 916ab0f into KaotoIO:main May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting a step with the Details panel open don't close it automatically
3 participants