This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
feat: Support editing steps from multiple flows #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Codecov Report
@@ Coverage Diff @@
## main #1770 +/- ##
==========================================
+ Coverage 65.84% 65.88% +0.03%
==========================================
Files 74 74
Lines 2199 2210 +11
Branches 507 510 +3
==========================================
+ Hits 1448 1456 +8
- Misses 706 708 +2
- Partials 45 46 +1
|
igarashitm
previously approved these changes
May 9, 2023
igarashitm
previously approved these changes
May 10, 2023
Currently we're calculating the step's ids by leveraging object references, this come handy for branches but presents the problem of leaking object references between single and multiple flows. This commit leverages lodash.clonedeep dependency to make a copy of the steps as a workaround for those situations. This should change in the future with a more robust solution like immer. relates to: #801
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This commit adds the functionality to edit steps from multiple flows
related: #801