Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Use parameter titles as labels for forms #1780

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

mmuzikar
Copy link
Contributor

Closes #1534
Needs KaotoIO/kaoto-backend#650 to work properly

@mmuzikar mmuzikar requested a review from a team May 11, 2023 10:41
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #1780 (aaedce9) into main (0eb26f3) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1780      +/-   ##
==========================================
- Coverage   65.84%   65.73%   -0.12%     
==========================================
  Files          74       74              
  Lines        2199     2212      +13     
  Branches      507      512       +5     
==========================================
+ Hits         1448     1454       +6     
- Misses        706      710       +4     
- Partials       45       48       +3     
Impacted Files Coverage Δ
src/services/stepsService.ts 76.86% <100.00%> (-0.56%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a final question, would be necessary to add id as a fallback as well? like:

label: title ?? id,

@mmuzikar
Copy link
Contributor Author

In this case it's better to leave the label undefined since autoform then tries to translate to a more human form. for example instead of aggregationStrategyMethodName it would use Aggregation Strategy Method Name

@lordrip
Copy link
Member

lordrip commented May 17, 2023

Alrighty, I saw that the associated backend pull request was merged already KaotoIO/kaoto-backend#650. I'll merge this one then.

@lordrip lordrip merged commit 19ad508 into KaotoIO:main May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default config tab using id instead of title?
2 participants