This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
fix(chromatic): Fix validation errors that shows in chromatic #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the "chromatic" build step is tagging all commits as failed since there are a few errors showing up as now all endpoints are being mocked properly. This pull request adds a small validation until we have a better mocked setup to support all components and their stories. It also removes the SourceCodeEditor story as we're not providing the necessary http mocks to ensure that works properly.
Codecov Report
@@ Coverage Diff @@
## main #1869 +/- ##
==========================================
- Coverage 65.71% 65.64% -0.07%
==========================================
Files 73 73
Lines 2129 2131 +2
Branches 524 526 +2
==========================================
Hits 1399 1399
Misses 688 688
- Partials 42 44 +2
|
|
Kudos, SonarCloud Quality Gate passed!
|
Delawen
approved these changes
May 29, 2023
|
thanks @Delawen |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, the "chromatic" build step is tagging all commits as failed since there are a few errors showing up as now all endpoints are being mocked properly.
This pull request adds a small validation until we have a better-mocked setup to support all components and their stories.
It also removes the
SourceCodeEditorstory as we're not providing the necessary HTTP mocks to ensure that works properly.