Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Add wait for API response before code sync #1879

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented May 31, 2023

Add wait for API response before the code-sync is performed to the e2e tests.

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #1879 (1b602fd) into main (ac1a3c3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1879   +/-   ##
=======================================
  Coverage   57.93%   57.93%           
=======================================
  Files          70       70           
  Lines        2439     2439           
  Branches      566      566           
=======================================
  Hits         1413     1413           
  Misses        976      976           
  Partials       50       50           

@tplevko tplevko force-pushed the fix_wait_before_sync branch 8 times, most recently from 4274ed8 to 0edb218 Compare June 1, 2023 05:57
@lordrip
Copy link
Member

lordrip commented Jun 1, 2023

@tplevko, do you think that it might be a good idea to introduce the "busy" concept as a matter to signal that the UI is doing something?

It might not be available for all circumstances and also we would need to check if impacts negatively the UI, but apart from that, I'm wondering if that would be helpful for the e2e.

The way that I imagine it, is that whenever you hit the sync button, there's an attribute set as "busy" and whenever the response is back, we switch it to "ready" or something like that. Maybe we could do something like that for the canvas as well.

@tplevko
Copy link
Contributor Author

tplevko commented Jun 1, 2023

In case it wouldn't negatively impact the UX, the "busy" concept could be a way to go. However for now I'd maybe leave as it is - the issues are only related to e2e tests, which are interacting with the UI "too quickly", causing the syncing issues with the backend, so I hope this could be solved with the waits for API responses.

@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tplevko tplevko marked this pull request as ready for review June 1, 2023 11:02
@tplevko tplevko requested a review from a team June 1, 2023 11:02
@lordrip
Copy link
Member

lordrip commented Jun 1, 2023

Sorry @tplevko, I didn't meant for you to do it 😄 , I meant if it could be helpful for the e2e in the future, so I could start thinking on that and makes our lives easier and tested

@lordrip lordrip merged commit 0f7c0fa into KaotoIO:main Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants