This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
feat(viz): Provide an empty state for the canvas #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good! |
igarashitm
previously approved these changes
Jun 14, 2023
lordrip
commented
Jun 14, 2023
| <Background color="#aaa" gap={16} /> | ||
| </ReactFlow> | ||
| </div> | ||
| {visibleFlowsInformation.isCanvasEmpty ? ( |
There was a problem hiding this comment.
OMG, I forgot to add tests for this clause, I'll add this test case and merge it afterward.
@tplevko covering this condition at the integration test side would be enough or should we add an e2e as well?
There was a problem hiding this comment.
Here we have the missing test
There was a problem hiding this comment.
Well from my POV, I think the test you added should be enough, can add more testing for this in e2e if requested.
Currently, whenever there's no visible route in the canvas, a full gray area is shown. The goal for this commit is to provide more information to the user about the status of the routes in the canvas itself. When there's no visible routes, an according message will be displayed.
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #1967 +/- ##
==========================================
+ Coverage 60.25% 60.72% +0.46%
==========================================
Files 76 78 +2
Lines 2521 2546 +25
Branches 565 576 +11
==========================================
+ Hits 1519 1546 +27
- Misses 955 956 +1
+ Partials 47 44 -3
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, whenever there's no visible route in the canvas, a full gray area is shown.
Changes
The goal for this commit is to provide more information to the user about the status of the routes in the canvas itself. When there are no visible routes, an according message will be displayed.
No visible routes
No routes
fixes: #1909