Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Replace placeholder - first step insert on index 0 #2006

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented Jun 21, 2023

fixes: #1962

Instead of appending the step instead of the placeholder - add it to index 0.
This prevents the mentioned issue, when there are other steps already defined in the route.

@tplevko tplevko requested a review from a team June 21, 2023 09:21
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #2006 (3331edf) into main (48fa76c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2006   +/-   ##
=======================================
  Coverage   64.85%   64.85%           
=======================================
  Files          87       87           
  Lines        2828     2828           
  Branches      651      651           
=======================================
  Hits         1834     1834           
  Misses        948      948           
  Partials       46       46           
Impacted Files Coverage Δ
src/services/stepsService.ts 71.92% <100.00%> (ø)

@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@lordrip lordrip merged commit a007941 into KaotoIO:main Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reinserting first step leads to new created routes with no links
3 participants