Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Fix e2e tests after backend quarkus update #2009

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Conversation

mkralik3
Copy link
Contributor

CORS needs to be set after Quarkus3 update on backend KaotoIO/kaoto-backend#695
More info

@mkralik3 mkralik3 requested a review from a team June 21, 2023 19:19
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #2009 (483abb5) into main (6451d32) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2009   +/-   ##
=======================================
  Coverage   64.85%   64.85%           
=======================================
  Files          87       87           
  Lines        2828     2828           
  Branches      651      651           
=======================================
  Hits         1834     1834           
  Misses        948      948           
  Partials       46       46           

see 1 file with indirect coverage changes

Copy link
Contributor

@igarashitm igarashitm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although these 2 are still failing, I think it's a separate problem. This fix improves the situation for sure. Actually these 2 are failing also locally for me.

  • 04-source_code/source_code.cy.js
  • 08-code-editor-actions/code_editor_actions.cy.js

@mkralik3
Copy link
Contributor Author

If they were working before the Quarkus3 upgrade, maybe, there is another issue that backend tests didn't catch. I think we can merge this and investigate failing tests afterwards

cc: @tplevko

@igarashitm igarashitm merged commit a74033c into KaotoIO:main Jun 21, 2023
@lordrip
Copy link
Member

lordrip commented Jun 22, 2023

Either that or is not deployed yet 😭
image

@mkralik3
Copy link
Contributor Author

mkralik3 commented Jun 22, 2023

@lordrip
this PR doesn't resolve the nightly cluster, only e2e tests in UI test suite.
Also, I have asked mmelko and the nightly cluster was deployed manually and there is a trigger to refetch new backend image, so the deployment with ENV needs to be update manually there.

@tplevko tplevko mentioned this pull request Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants