This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
fix(vscode): Routes gets reset upon opening in vscode. #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there are two effects taking care of the syncing process between the VS Code file and KaotoUI (and source code) in the KogitoEditorIntegrationProvider.tsx file. Said effects reacts when one of the several dependencies changes, like flows or settings. This causes a recursive call since the same effects are updating the setting object from which they depends. The fix is for the effect to rely only in the intended property. This is still colliding with the Sourcecode sync that it's happening in the Visualization.tsx component. A follow up will be needed to consolidate both scenarios. fixes: KaotoIO/vscode-kaoto#285
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #2034 +/- ##
==========================================
+ Coverage 64.78% 65.07% +0.28%
==========================================
Files 87 87
Lines 2837 2849 +12
Branches 652 656 +4
==========================================
+ Hits 1838 1854 +16
+ Misses 953 948 -5
- Partials 46 47 +1
|
|
Tested locally in VS Code and I do not reproduce anymore the initial issue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, there are two effects taking care of the syncing process between the VS Code file and KaotoUI (and source code) in the
KogitoEditorIntegrationProvider.tsxfile. Said effects react when one of the several dependencies changes, like flows or settings.This causes a recursive call since the same effects are updating the setting object from which they depend.
Changes
The fix is for the effect to rely only on the intended property.
This is still colliding with the Sourcecode sync that it's happening in the
Visualization.tsxcomponent. A follow-up will be needed to consolidate both scenarios.fixes: KaotoIO/vscode-kaoto#285