This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
fix(steps): Cannot update steps that doesn't contain parameters #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if a step doesn't contain parameters, like the do/try step, is ignored in the updateStepParameters method. The fix is to fill in the parameters with the newValues object if provided, and from that point forward, insert the step in the store since a step extension could modify it. fixes: #2051
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #2105 +/- ##
==========================================
+ Coverage 67.15% 67.49% +0.34%
==========================================
Files 89 89
Lines 2886 2883 -3
Branches 667 666 -1
==========================================
+ Hits 1938 1946 +8
+ Misses 902 892 -10
+ Partials 46 45 -1
|
igarashitm
approved these changes
Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, if a step doesn't contain parameters, like the do/try step, is ignored in the updateStepParameters method.
Changes
The fix is to fill in the parameters with the newValues object if provided, and from that point forward, insert the step in the store since a step extension could modify it.
fixes: #2051
fixes: #2052
fixes: #2053