Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

fix: [VS Code] Modifying beans is not marking editor dirty #2143

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

igarashitm
Copy link
Contributor

Fixes: #2133

2023-07-13_12-48-32.mp4

@igarashitm igarashitm requested a review from a team July 13, 2023 16:58
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #2143 (aef9b36) into main (b55ee0d) will increase coverage by 2.32%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2143      +/-   ##
==========================================
+ Coverage   68.40%   70.73%   +2.32%     
==========================================
  Files          91       91              
  Lines        2988     2993       +5     
  Branches      696      700       +4     
==========================================
+ Hits         2044     2117      +73     
+ Misses        899      835      -64     
+ Partials       45       41       -4     
Impacted Files Coverage Δ
...to-integration/KogitoEditorIntegrationProvider.tsx 70.12% <100.00%> (+70.12%) ⬆️

... and 2 files with indirect coverage changes

@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.4% 3.4% Duplication

@lordrip lordrip merged commit 7528db9 into KaotoIO:main Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VS Code] Modifying beans is not marking editor dirty
2 participants