Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Release pipeline action #770

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

oscerd
Copy link
Contributor

@oscerd oscerd commented Feb 2, 2024

Fixes #746

Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @oscerd.

I have a couple of questions that I would like to ask:

  1. The current order is tag-and-release, npm-release, container-image-release, I wonder if it would make sense to start with the npm-release first, this way, if we try to release a broken commit by accident, this build step will fail, hence preventing the container and the release to be generated.

  2. We build the project a few times in different workflows, if we wanted to avoid redefining the build process in all of them, would be a custom action the way to go?

@lordrip lordrip merged commit c42b69f into KaotoIO:main Feb 2, 2024
9 checks passed
@oscerd
Copy link
Contributor Author

oscerd commented Feb 2, 2024

Awesome, thanks @oscerd.

I have a couple of questions that I would like to ask:

  1. The current order is tag-and-release, npm-release, container-image-release, I wonder if it would make sense to start with the npm-release first, this way, if we try to release a broken commit by accident, this build step will fail, hence preventing the container and the release to be generated.

Yes, we can simply switch

  1. We build the project a few times in different workflows, if we wanted to avoid redefining the build process in all of them, would be a custom action the way to go?

We can define a build action and we could re-use it from other workflow by having that defined as custom action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a release container image
2 participants