Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Chapter changing when scrolling on webtoons #3007

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Bugfix: Chapter changing when scrolling on webtoons #3007

merged 2 commits into from
Jun 29, 2024

Conversation

Zackareee
Copy link
Contributor

@Zackareee Zackareee commented Jun 19, 2024 •
edited
Loading

Fixed

When scrolling quickly, this.atBottom isn't always being set to True.

Fix by setting this.atBottom when totalScroll is greater than totalHeight.
Then, this.checkIfShouldTriggerContinuousReader() will load the next chapter.

@majora2007
Copy link
Member

From initial testing, I don't see anything breaking.

@majora2007 majora2007 changed the base branch from develop to feature/reader-changes June 29, 2024 15:28
@majora2007 majora2007 merged commit 4e4d669 into Kareadita:feature/reader-changes Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webtoons on mobile doesn't scroll to the next chapter
2 participants
@Zackareee @majora2007