Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart getProperty(... was too smart with container runtime property #176

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

Karm
Copy link
Owner

@Karm Karm commented Aug 8, 2023

Regression caused by fed26dd, happens for some podman settings on command line, e.g.

mvn clean verify -Ptestsuite-builder-image -Dquarkus.version=3.2.3.Final -Dquarkus.native.container-runtime=podman

must work too. Not just QUARKUS_NATIVE_CONTAINER_RUNTIME env prop.

@Karm Karm self-assigned this Aug 8, 2023
Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this transformation of alternative names takes a mental toll :-/ I've once run into this weirdness myself.

@Karm Karm merged commit a1c49ae into master Aug 9, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants