Improved logging. #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing logging is print-based and often fails to contain useful information. Logging is now done with the logging module, with debug logs going to file and info to console. Logging levels are raised to errors for testing to minimize spam.
|
|
||
| # 2) Create/Get Protein and save values | ||
| try: | ||
| protein = ProteinModel.objects.get(code=code) | ||
| print ' Existing protein: ', code | ||
| logger.debug('protein exists') |
There was a problem hiding this comment.
Should there be a bit more information here about which protein exists or does not exist?
There was a problem hiding this comment.
On line 224, the logger is defined as coming from the pdb['logger'] value, which was set on line 201 from the variable which is assigned on line 198. The argument to the getLogger() call is equal to the code of the protein. That string is prefixed to all calls that logger makes, including the "protein exists" call.
The old logging output looked like this:
Existing protein: 1XYZ
The new output looks like this:
1XYZ DEBUG protein exists
Does that help?
|
I like moving away from [the python 2.X] printing as a form of debugging and toward a more standard logging system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing logging is print-based and often fails to contain useful information.
Logging is now done with the logging module, with debug logs going to file and info to console. Logging levels are raised to errors for testing to minimize spam.