Skip to content

Commit

Permalink
shorten get_most_qual_cls_name to most_qual_cls_name
Browse files Browse the repository at this point in the history
  • Loading branch information
artgoldberg committed Dec 10, 2016
1 parent 0a436c9 commit a895643
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
14 changes: 7 additions & 7 deletions tests/util/test_misc.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
'''

import unittest
from wc_utils.util.misc import get_most_qual_cls_name
from wc_utils.util.misc import most_qual_cls_name
from wc_utils.util.stats import ExponentialMovingAverage

class C(object):
Expand All @@ -20,16 +20,16 @@ class TestMisc(unittest.TestCase):
def test_get_qual_name(self):

ema = ExponentialMovingAverage(1, .5)
self.assertEqual(get_most_qual_cls_name(self), 'tests.util.test_misc.TestMisc')
self.assertEqual(get_most_qual_cls_name(TestMisc), 'tests.util.test_misc.TestMisc')
self.assertEqual(get_most_qual_cls_name(ema),
self.assertEqual(most_qual_cls_name(self), 'tests.util.test_misc.TestMisc')
self.assertEqual(most_qual_cls_name(TestMisc), 'tests.util.test_misc.TestMisc')
self.assertEqual(most_qual_cls_name(ema),
'wc_utils.util.stats.ExponentialMovingAverage')
self.assertEqual(get_most_qual_cls_name(ExponentialMovingAverage),
self.assertEqual(most_qual_cls_name(ExponentialMovingAverage),
'wc_utils.util.stats.ExponentialMovingAverage')

try:
# Fully qualified class names are available for Python >= 3.3.
hasattr(self, '__qualname__')
self.assertEqual(get_most_qual_cls_name(d), 'tests.util.test_misc.C.D')
self.assertEqual(most_qual_cls_name(d), 'tests.util.test_misc.C.D')
except:
self.assertEqual(get_most_qual_cls_name(d), 'tests.util.test_misc.D')
self.assertEqual(most_qual_cls_name(d), 'tests.util.test_misc.D')
2 changes: 1 addition & 1 deletion wc_utils/util/misc.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def isclass_by_name(cls_name, cls_info):

return False

def get_most_qual_cls_name(obj):
def most_qual_cls_name(obj):
"""Obtain the most qualified class name available for `obj`.
Since references to classes cannot be sent in messages that leave an address space,
Expand Down

0 comments on commit a895643

Please sign in to comment.