This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
activity-memory-leak-fix: DexterInstance calls context.getApplication… #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Context() to avoid leaks if the user initializes Dexter inside an Activity. Also, DexterInstance now holds the reference in a WeakReference variable. May need to add null checks around weakReferenceActivity.get(). EO
Closed
|
Hi @emmano In a recent PR we have fixed the inner The |
|
Please, merge master into your branch to solve conflicts and we will release a new version with it. Thanks! |
|
Update branch with master and 👍 |
Conflicts: dexter/src/test/java/com/karumi/dexter/DexterInstanceTest.java
|
Sorry. Didn't see you guys updated master. Everything should be up to date now. |
|
@Serchinastico do we have your 👍 ? |
|
Sure, I'll close the door :) |
Serchinastico
added a commit
that referenced
this pull request
Dec 1, 2015
DexterInstance calls context.getApplication…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Context() to avoid leaks if the user initializes Dexter inside an Activity. Also, DexterInstance now holds the reference in a WeakReference variable. May need to add null checks around weakReferenceActivity.get(). EO