02-room #6
02-room #6
Conversation
| @Entity(tableName = "superheroes") | ||
| data class SuperHeroEntity( | ||
| @PrimaryKey val id: String, | ||
| @Embedded(prefix = "superhero_") val superHero: SuperHero |
There was a problem hiding this comment.
Seems to me that Embedded is an advanced feature of Room, we could simplify this for the course, even if it's more verbose.
There was a problem hiding this comment.
Also not sure about the effect you want to have as SuperHero as already an id and the prefix of these fields.
the table will have
superheroes.id and superheroes. superhero_id
There was a problem hiding this comment.
Actually it was just a test to see how @Embedded work, in this case we had two copies of the same model, SuperHero and SuperHeroEntity, just wanted to try having the domain model stored in DB instead of a DB-only model.
If we go this way we can remove the outer id and configure the primary key from the @Entity annotation instead.
| import com.karumi.jetpack.superheroes.data.repository.room.SuperHeroDao | ||
| import com.karumi.jetpack.superheroes.data.repository.room.SuperHeroEntity | ||
|
|
||
| @Database(entities = [SuperHeroEntity::class], version = 2) |
There was a problem hiding this comment.
There is a neat way to test database migration would be nice to have it included, even if not required during the exercises.
https://developer.android.com/training/data-storage/room/migrating-db-versions#export-schema
There was a problem hiding this comment.
Yeah, the PR is mid development, yesterday I started creating all tests and I'm using that approach, I only exported v2 schema because I did it late in the process but I'm adding schema-v1 as well
|
Why not split this exercise into two parts? First without migration for devs, that just want to download everything again using |
|
|
||
| private val from1To2 = object : Migration(1, 2) { | ||
| override fun migrate(database: SupportSQLiteDatabase) { | ||
| database.execSQL("DROP TABLE superheroes") |
There was a problem hiding this comment.
Was there a superheroes table before ?
|
Just realize that version 1 of the database is in the first commit, but not visible in the PR. |
|
I'm going to split the exercise in 2 as you said, |
|
Great
…On Wed, Jan 30, 2019 at 10:22 AM Sergio Gutiérrez ***@***.***> wrote:
I'm going to split the exercise in 2 as you said, 02a-room having the
basics of Room with no migrations and 02b-room-migrations with the
migration to use @Embedded, migrations and migration tests. I'll let you
know when I'm done
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA0X6jtjHCxqrOJU1t6BPuqUirpWyw0gks5vIWRhgaJpZM4aYrlp>
.
--
Davide Mendolia
Co-Founder and Full Stack engineer @ Karumi
|
This PR is not meant to be merged
This is how to include Room inside the project:
SuperHero. Now we use the@Embeddedannotation to get an object and split all its fields into fields of the table (preffixed with the string "superhero_").