This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
fixes #21270 - custom certificates added to backup #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean797
reviewed
Oct 12, 2017
katello/backup.rb
Outdated
| scenario_answers["certs"]["server_cert"], | ||
| scenario_answers["certs"]["server_key"], | ||
| scenario_answers["certs"]["server_cert_req"], | ||
| scenario_answers["certs"]["server_ca_cert"] |
There was a problem hiding this comment.
is it just me or is the alignment off ?
There was a problem hiding this comment.
👍 great catch, fixing now
There was a problem hiding this comment.
Actually @sean797 it's correct, just looks strange here. If you look at "raw" code without the markup, you'll see it is aligned correctly.
There was a problem hiding this comment.
Its because you've used a tab 😈 please use spaces
|
Works on a local setup w/o custom certs for both server + capsule, but I would like to test this on a system with custom certs. The only one I have access to isn't available today, but I can use it next week, I'll test and comment back here |
johnpmitsch
approved these changes
Oct 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.