-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for private registry on Megalos #282
base: 283-private-registry-support-on-megalos
Are you sure you want to change the base?
Add support for private registry on Megalos #282
Conversation
- Why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @GioBar00.
thanks for the PR and sorry for the delay.
I suggest some changes on your code that I would like to discuss before merging the PR.
Thanks,
Mariano.
I modified the code with the suggestions above. |
…specified file and store as base64 string. Added Docker Config JSON Validator and related exception. Added default value option in setting-utils `read_value`. Added custom read for docker config json.
Hi @GioBar00, I will check the changes tomorrow and if everything is ok I will merge the PR in the |
- What I did
private_registry_dockerconfigjson
for a base64-encoded docker configuration.private-registry
of typekubernetes.io/dockerconfigjson
.image_pull_secret
argument to the pod specification referring to theprivate-registry
secret.- How I did it
KubernetesSettingsAddon.py
to add the new settingprivate_registry_dockerconfigjson
.KubernetesOptionHandler.py
to add the cli menu to enter or delete the setting.KubernetesNamespace.py
to create theprivate-registry
secret if the setting is set right after creating the namespace.KubernetesMachine.py
to add theimage_pull_secret
argument to the pod specification referring to theprivate-registry
secret if the setting is set.- How to verify it
Create a private registry and get the docker config. Example of the file structure:
Compute the base64 encoding of the docker config and add it to Kathara settings.
Deploy a lab with
kathara lstart
or a machine withkathara vstart
with an image available on the private registry.- Description for the changelog
Added support for private registries on Megalos
Resolves #283.