Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change name property on class Action.js #5

Closed
Katreque opened this issue Nov 6, 2020 · 2 comments
Closed

Change name property on class Action.js #5

Katreque opened this issue Nov 6, 2020 · 2 comments
Assignees
@Katreque
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Katreque
Copy link
Owner

Katreque commented Nov 6, 2020 •
edited
Loading

  • Change the default property from name to id on the Action class. (src/classes/Action.js)
  • Should accept string or number.
@Katreque Katreque added enhancement New feature or request good first issue Good for newcomers labels Nov 6, 2020
@Katreque Katreque mentioned this issue Nov 6, 2020
Closed
@Katreque Katreque changed the title Change Variable on class Action.js Change name property on class Action.js Nov 6, 2020
@Katreque Katreque self-assigned this Dec 3, 2020
@Katreque
Copy link
Owner Author

Katreque commented Dec 3, 2020

Working on it.

Katreque added a commit that referenced this issue Dec 3, 2020
@Katreque
Solution to Issue #5.
08959c7
@Katreque
Copy link
Owner Author

Katreque commented Dec 3, 2020

Done.

@Katreque Katreque closed this as completed Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Katreque Katreque

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Katreque