Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with null priority and rewatch/reread value #255

Merged
merged 6 commits into from
Nov 14, 2021

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Nov 10, 2021

Prerequisites

If checks are not passed then the pull request will be closed.

  • I have checked that no other similar pull request already exists.
  • My code follows the general code style as the rest of the code.
  • I have checked that no sensitive information is exposed.
  • Build compiles.
  • Build passes test cases.

GitHub Copilot Disclaimer

The use of GitHub Copilot is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot.

Workflow Run

https://github.com/Katsute/Mal4J/actions/runs/1459709427

Changes Made

List any changes made and/or other relevant issues.

  • Fix issue where list could not be updated if it had a null priority or rewatch/reread value
  • Backup anime & manga lists before testing
  • Update issue templates
  • Update README
  • Fix seasons test

@Katsute Katsute added the bug label Nov 10, 2021
@Katsute Katsute self-assigned this Nov 10, 2021
@Katsute Katsute changed the title Fix issue will null priority and rewatch/reread value Fix issue with null priority and rewatch/reread value Nov 10, 2021
@Katsute Katsute marked this pull request as ready for review November 10, 2021 23:53
@Katsute
Copy link
Member Author

Katsute commented Nov 14, 2021

todo: fix failing seasons test

@Katsute Katsute merged commit 4bfe862 into main Nov 14, 2021
@Katsute Katsute deleted the fix-null-update-enum@29e7171 branch November 14, 2021 20:51
@ghost ghost locked and limited conversation to collaborators Nov 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot update watchlist anime/manga status without giving priority and rewatch/reread value (NPE)
1 participant