Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for M1 #79

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Conversation

lucasschoenhold
Copy link
Contributor

Added Support for M1 Macs

Compiler flag '-march=native' and the maximal allowed version 1.5.11 of pyglet have prevented nes-py from being installed on M1 Macs.

Type of change

Please select all relevant options:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Local installation on M1 Mac
  • Local installation on Intel based Mac

Test Configuration

  • Operating System: macOS 12.0.1 (M1), macOS 11.6 (Intel)
  • Python version: 3.8 & 3.9
  • C++ compiler version: C++17

@lucasschoenhold lucasschoenhold changed the title fix: Support for M1 Support for M1 Nov 4, 2021
@mshr-h
Copy link

mshr-h commented Jan 2, 2022

I've also tested your change on my M1 Mac and it worked correctly.

@Kautenja Kautenja merged commit 0e4a7d4 into Kautenja:master Jun 7, 2022
@Kautenja
Copy link
Owner

Kautenja commented Jun 7, 2022

Sorry for the delay, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants