fix: update ledger-cosmos-go v0.13.1 to resolve signing error with cosmos ledger app 2.34.12 #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galxy25
approved these changes
Nov 16, 2023
Incorrect kava.2 tag
drklee3
added a commit
that referenced
this pull request
Nov 16, 2023
…smos ledger app 2.34.12 (#1770) * Update ledger-cosmos-go v0.13.1 with cosmos fork update * Bump cosmos-sdk v0.46.11-kava.2 * Update changelog * Update cosmos-sdk tag v0.46.11-kava.3 Incorrect kava.2 tag
drklee3
added a commit
that referenced
this pull request
Nov 17, 2023
…smos ledger app 2.34.12 (backport #1770) (#1771) * fix: update ledger-cosmos-go v0.13.1 to resolve signing error with cosmos ledger app 2.34.12 (#1770) * Update ledger-cosmos-go v0.13.1 with cosmos fork update * Bump cosmos-sdk v0.46.11-kava.2 * Update changelog * Update cosmos-sdk tag v0.46.11-kava.3 Incorrect kava.2 tag (cherry picked from commit 3914674) # Conflicts: # CHANGELOG.md # go.mod # go.sum * Update conflicts in go.mod * Update changelog --------- Co-authored-by: drklee3 <derrick@dlee.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cosmos ledger app 2.34.12 fails to sign txs on ledger-cosmos-go v0.12.2
Tested ledger signing with cosmos ledger app 2.34.12:
Checklist