-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #41 #42
Fix #41 #42
Conversation
Sorry for the commit mess, as mentioned in the issue I did only little investigation on whether it breaks another parts of software. |
Hello @moojek and thanks for contributing to this project! Could you also add a simple test for this? Then I could also more easily verify the functionality 👍 Also wondering what is wrong with the CI with older Ubuntu version. Maybe I need to update the version used for testing. Looks like they are quite old. |
Thanks for the warm welcome. edit: typo |
Thanks @moojek for noticing the Ubuntu issue. I merged a PR to fix them and now all CI stuff should turn to green. Can you rebase your changes on latest master? |
Okay @Kazhuu, so I updated the CI and committed a really simple test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested and works very good. Thank you for contributing and implementing a test for this! Much appreciated 👍
fixes #41