Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #41 #42

Merged
merged 5 commits into from
May 27, 2023
Merged

Fix #41 #42

merged 5 commits into from
May 27, 2023

Conversation

moojek
Copy link
Contributor

@moojek moojek commented May 20, 2023

fixes #41

@moojek
Copy link
Contributor Author

moojek commented May 20, 2023

Sorry for the commit mess, as mentioned in the issue I did only little investigation on whether it breaks another parts of software.

@Kazhuu
Copy link
Owner

Kazhuu commented May 23, 2023

Hello @moojek and thanks for contributing to this project! Could you also add a simple test for this? Then I could also more easily verify the functionality 👍 Also wondering what is wrong with the CI with older Ubuntu version. Maybe I need to update the version used for testing. Looks like they are quite old.

@moojek
Copy link
Contributor Author

moojek commented May 23, 2023

Hello @moojek and thanks for contributing to this project! Could you also add a simple test for this? Then I could also more easily verify the functionality 👍 Also wondering what is wrong with the CI with older Ubuntu version. Maybe I need to update the version used for testing. Looks like they are quite old.

Thanks for the warm welcome.
Looks like Ubuntu 18.04 runners are deprecated: https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/.
Also I will try to supply some tests and have a deeper look at the implications of the changes too.

edit: typo

@Kazhuu
Copy link
Owner

Kazhuu commented May 24, 2023

Thanks @moojek for noticing the Ubuntu issue. I merged a PR to fix them and now all CI stuff should turn to green. Can you rebase your changes on latest master?

@moojek
Copy link
Contributor Author

moojek commented May 24, 2023

Okay @Kazhuu, so I updated the CI and committed a really simple test

Copy link
Owner

@Kazhuu Kazhuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and works very good. Thank you for contributing and implementing a test for this! Much appreciated 👍

@Kazhuu Kazhuu merged commit 10158f9 into Kazhuu:main May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Program crashes on comments that include dots
2 participants