Feature interface WIP #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I extremely dislike polluting EntityManager even more. Even extending is a bad idea. |
|
@hosiplan: By the way, what about switching to EntityManagerDecorator for in 2.4? Not sure how well it is supported in doctrine's internal (there were some issues with typehinting EntityManager directly IIRC; see doctrine/orm@acc8b61#commitcomment-4018282). |
|
Sure I will move it. I was not sure about EntityManager config anyway since this is global configuration. |
|
@mishak87 thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses [Closes #40] and [Closes #41]
Added to get some feedback and to show somebody is working on this.