Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for PHP 8.0 #100

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Added support for PHP 8.0 #100

merged 1 commit into from
Apr 14, 2021

Conversation

KacerCZ
Copy link
Contributor

@KacerCZ KacerCZ commented Jan 26, 2021

  • Allow installation on PHP 8.0
  • Fixed compatibility with PHP 8.0 namespace handling
  • Ignore platform requirements on PHP 8.0 because of incompatible dev dependency
  • Updated download URL for phpredis extension
  • Fixed warning for phpstan.neon

@KacerCZ KacerCZ force-pushed the php8-support branch 2 times, most recently from 8618e8c to 308f502 Compare January 28, 2021 06:03
@KacerCZ KacerCZ mentioned this pull request Jan 28, 2021
@KacerCZ
Copy link
Contributor Author

KacerCZ commented Jan 28, 2021

@Vboss Please take a look if this PR is acceptable for you.

Now it is not possible to install it on PHP 8 with development dependencies (consistence/coding-standard#65).
Dependencies in "require" part are compatible with PHP 8.

@KacerCZ
Copy link
Contributor Author

KacerCZ commented Feb 18, 2021

@Vboss kindly ping

@martinvenus
Copy link

I have made some tests and it works without any problem at my app. I could only suggest to also update README.md ("Kdyby/Redis requires PHP 7.1 to PHP 7.4." => "Kdyby/Redis requires PHP 7.1 to PHP 8.0.").

Thanks. Good job.

- Allow installation on PHP 8.0 and newer
- Fixed compatibility with PHP 8.0 namespace handling
- Ignore platform requirements on PHP 8.0 because of incompatible dev dependency
- Updated download URL for phpredis extension
- Fixed warning for phpstan.neon
@KacerCZ
Copy link
Contributor Author

KacerCZ commented Feb 23, 2021

@martinvenus Thanks for spotting issue in README.
I'm using this package on PHP 8 without any problems.

I changed PHP constraint to 7.1 or newer in composer.json to eliminate the need for anybody go back when PHP 9 is released.

@KacerCZ KacerCZ mentioned this pull request Feb 24, 2021
@martinvenus
Copy link

Is there anything I can do for this PR to be merged (and new version release)?

@KacerCZ
Copy link
Contributor Author

KacerCZ commented Mar 23, 2021

Anything more needs to be done from my side to accept this PR and release new version?

@elcheco
Copy link

elcheco commented Apr 7, 2021

@Vboss @fprochazka - Is there any active maintainer who could check this PR?

@Spamercz
Copy link
Member

Ignore platform requirements on PHP 8.0 because of incompatible dev dependency

What dependecy?

Updated download URL for phpredis extension

You are using development version of redis extension, this may be deal breaker for some companies/hosting policy.

Oh i see they renamed that, in that case this is fine 👍 . Is there release of redis extension with oficial PHP8 support, so I can add that information to release notes?

@KacerCZ
Copy link
Contributor Author

KacerCZ commented Apr 14, 2021

Ignore platform requirements on PHP 8.0 because of incompatible dev dependency

What dependecy?

Used coding standard is not installable on PHP 8 - see consistence/coding-standard#65

Updated download URL for phpredis extension

You are using development version of redis extension, this may be deal breaker for some companies/hosting policy.

Oh i see they renamed that, in that case this is fine +1 . Is there release of redis extension with oficial PHP8 support, so I can add that information to release notes?

PHP 8 is supported since version 5.3.0 of redis extension.
Source: https://pecl.php.net/package-info.php?package=redis&version=5.3.0

@Spamercz
Copy link
Member

Great, coding standard is something that can be resolved later, but is important to know what is failing to install :) . I dont want to give exact timeframe but at our company we have to deal with same problem in comming months so after that hopefully we can fix it here too.

Anyway lets merge this, thank you all :)

@Spamercz Spamercz merged commit d963dfe into Kdyby:master Apr 14, 2021
@KacerCZ
Copy link
Contributor Author

KacerCZ commented Apr 14, 2021

@Vboss Thank you for review and publishing new version.

@KacerCZ KacerCZ deleted the php8-support branch April 14, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants