-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for PHP 8.0 #100
Conversation
KacerCZ
commented
Jan 26, 2021
•
edited
Loading
edited
- Allow installation on PHP 8.0
- Fixed compatibility with PHP 8.0 namespace handling
- Ignore platform requirements on PHP 8.0 because of incompatible dev dependency
- Updated download URL for phpredis extension
- Fixed warning for phpstan.neon
8618e8c
to
308f502
Compare
@Vboss Please take a look if this PR is acceptable for you. Now it is not possible to install it on PHP 8 with development dependencies (consistence/coding-standard#65). |
@Vboss kindly ping |
I have made some tests and it works without any problem at my app. I could only suggest to also update README.md ("Kdyby/Redis requires PHP 7.1 to PHP 7.4." => "Kdyby/Redis requires PHP 7.1 to PHP 8.0."). Thanks. Good job. |
- Allow installation on PHP 8.0 and newer - Fixed compatibility with PHP 8.0 namespace handling - Ignore platform requirements on PHP 8.0 because of incompatible dev dependency - Updated download URL for phpredis extension - Fixed warning for phpstan.neon
93188d4
to
3ebb535
Compare
@martinvenus Thanks for spotting issue in README. I changed PHP constraint to 7.1 or newer in |
Is there anything I can do for this PR to be merged (and new version release)? |
Anything more needs to be done from my side to accept this PR and release new version? |
@Vboss @fprochazka - Is there any active maintainer who could check this PR? |
What dependecy?
Oh i see they renamed that, in that case this is fine 👍 . Is there release of redis extension with oficial PHP8 support, so I can add that information to release notes? |
Used coding standard is not installable on PHP 8 - see consistence/coding-standard#65
PHP 8 is supported since version 5.3.0 of redis extension. |
Great, coding standard is something that can be resolved later, but is important to know what is failing to install :) . I dont want to give exact timeframe but at our company we have to deal with same problem in comming months so after that hopefully we can fix it here too. Anyway lets merge this, thank you all :) |
@Vboss Thank you for review and publishing new version. |