Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast integer message id to string #154

Merged
merged 2 commits into from Aug 20, 2018

Conversation

Projects
None yet
2 participants
@lulco
Copy link
Contributor

commented Aug 10, 2018

Fix for error when using "Two dimensional" select:

$form = new Nette\Application\UI\Form();
$items = [
    '2017' => [
        '1',
        '2',
    ],
    '2018' => [
        '1',
        '2',
    ],
];
$form->addSelect('test', 'Test', $items);

Error was: "Message id must be a string, integer was given". As you can see, I was trying to use strings as keys for $items array, but PHP uses integer for key always if it is made up of only digits :(

lulco added some commits Aug 10, 2018

@lulco lulco changed the title Allow integer message id Cast integer message id to string Aug 11, 2018

@enumag enumag merged commit b892e00 into Kdyby:master Aug 20, 2018

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.1%) to 69.77%
Details
Scrutinizer 10 new issues, 1 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lulco lulco deleted the lulco:integer-message branch Aug 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.