Nette 3.0 version #165
Merged
Nette 3.0 version #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be reverted, after kdyby/monolog compatible with Nette 3.0 is released
enumag
requested changes
Jul 21, 2019
fixes "Declaration of Nette\Bridges\ApplicationLatte\SnippetBridge::setSnippetMode($snippetMode) must be compatible with Latte\Runtime\ISnippetBridge::setSnippetMode(bool $snippetMode)"
|
Temporary dependency on my branch of kdyby/monolog removed, replaced with kdyby/monolog:^2.0, that was just released. |
|
Kdyby/translation is the only dependency preventing our projects to be upgraded to Nette 3. We are testing our project with haltuf/Translation and it seems ok. Can I help somehow to merge this PR? |
|
This PR is imho ready to be merged, I also didn't find any problem in real life nette 3.0 use case. The only possible problem is that I'm on out of office now, and won't be able to prepare hotfix (if needed) in the upcoming 2 weeks. |
enumag
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, sending PR to make Kdyby/Translation compatible with Nette v3.0
This PR is conditional of approving kdyby/monolog PR in here: Kdyby/Monolog#35
To make all tests work, I made temporary change (in d092f0e) to composer.json to make the package rely on the branch consisting of the content of this PR. This should be reverted/edited, once kdyby/monolog has a version compatible with Nette 3.0
The code should pass all the tests (at least it does on my travis, coveralls etc.), which unfortunatelly does not guarantee, that it will work, as the code coverage is quite low. Please help me with testing before approving this PR.
Anyone wishing to contribute to this PR, contact me and I can give you access.