Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently merged PR #3353 only partially fixes the overflow checking: All the taclets in
integerAssignment2UpdateRules.key
, which add another formula to the sequent for the overflow check, are missing the\sameUpdateLevel
constraint. This can lead to unprovable overflow check branches (see theinInt
line in the screenshot below, which talks about the variables_a
and_b
instead ofa
andb
).Btw.: I think that the bug is "only" a completeness issue and not soundness critical, since the variables can only appear in the inInt(...) predicate and the original modality and nowhere else on the sequent.
In addition to the fix in the rules, this PR adds test cases (one provable and one unprovable) for each of the test cases, which hopefully will help in the future to detect such problems earlier.
Related Issue
This pull request fixes the only partially corrected #3353.
This PR addresses #3487.
Type of pull request
\sameUpdateLevel
constraints)Ensuring quality
Additional information and contact(s)
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.