Delete old not_a_string_type test #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should probably remove all those checks no? |
|
They should be removed when the same has been done for those two constraint types, but I feel like it's reasonable to have the test for them until that's done, though looking at them that should be quickly done, hm. |
This test was checking that the derive macro assertion about the type not being one of the known string types was working, but now since we allow implementations of the email validation for third-party types there is no way for us to perform this check in the derive macro. The same assertion is still used for the credit card and non-control character validators, but those will also soon be switched to be trait-based.
kyrias
force-pushed
the
replace-not_a_string_type-test
branch
from
08da611
to
0520e3b
Compare
kyrias
changed the title
Keats
pushed a commit
that referenced
this pull request
Mar 4, 2024
This test was checking that the derive macro assertion about the type not being one of the known string types was working, but now since we allow implementations of the email validation for third-party types there is no way for us to perform this check in the derive macro. The same assertion is still used for the credit card and non-control character validators, but those will also soon be switched to be trait-based.
Keats
pushed a commit
that referenced
this pull request
Mar 4, 2024
This test was checking that the derive macro assertion about the type not being one of the known string types was working, but now since we allow implementations of the email validation for third-party types there is no way for us to perform this check in the derive macro. The same assertion is still used for the credit card and non-control character validators, but those will also soon be switched to be trait-based.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was checking that the derive macro assertion about the type not being one of the known string types was working, but now since we allow implementations of the email validation for third-party types there is no way for us to perform this check in the derive macro.
The same assertion is still used for the credit card and non-control character validators, but those will also soon be switched to be trait-based.