Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commander search #12

Closed
Kender2 opened this issue Dec 20, 2016 · 6 comments
Closed

Add commander search #12

Kender2 opened this issue Dec 20, 2016 · 6 comments

Comments

@Kender2
Copy link
Owner

Kender2 commented Dec 20, 2016

Add functionality to find a player through search.

Results show a list of matching commanders and their squad and faction.

Question is where to place the search box or link to search page.

@MidgetAl
Copy link

I would totally love this feature.

Keep up the good work.

@MidgetAl
Copy link

Any progress on this? As I say whenever I come around here ... coding is not my thing, so feel free to tell me to fuck off ... but this feature I think would be awesome ... just to see where old friends/enemies have moved on to.

@Kender2
Copy link
Owner Author

Kender2 commented Dec 29, 2016

I don't need help with coding this per se. But I'm having a hard time figuring out where to add the search function in the site.
For the desktop version it's easy enough to put a link, button or searchbox somewhere, but since most users are on mobiles (62% mobile, 18% tablet, 20% desktop) I prefer an elegant and intelligent solution.

@InsomniacEM
Copy link

InsomniacEM commented Dec 29, 2016 via email

spariev added a commit to spariev/swc-squadranking that referenced this issue Dec 30, 2016
@spariev
Copy link
Contributor

spariev commented Dec 30, 2016

oh snap, should have checked out the issue before coding the PR. Anyway, snippet with dropdown looks nice, should be easy to integrate.

spariev added a commit to spariev/swc-squadranking that referenced this issue Dec 30, 2016
spariev added a commit to spariev/swc-squadranking that referenced this issue Dec 30, 2016
spariev added a commit to spariev/swc-squadranking that referenced this issue Dec 30, 2016
spariev added a commit to spariev/swc-squadranking that referenced this issue Dec 30, 2016
@Kender2
Copy link
Owner Author

Kender2 commented Jan 8, 2017

Done

@Kender2 Kender2 closed this as completed Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants