-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
for repo review #31
for repo review #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work my man! very clear and concise code, well documented and easy to follow along.
a couple of points:
- It would be optimal if
yield_original
when used in combination withset_doc_level
did not yield the same Example twice if no augmentation took place. - An extra getting started/appetizer section would help new users adopt easier. The notebook is great, but it takes some effort to get there, and some users might get lost/impatient before working through the example. Perhaps a very short example directly in the README so users do not have to refer to the documentation for an API example
- we should consider adding a tutorial showing how to train a new spaCy model using the augmenters (also for own reference)
- relatedly, we should consider making a couple of sample combinations of augmenters with sensible defaults for model training/model evaluation (could be part of the tutorial)
- check the comments for a couple of other small notes
I will give the readme/docs/notebook a read through for grammar tomorrow
Co-authored-by: HLasse <lasseh0310@gmail.com>
Co-authored-by: HLasse <lasseh0310@gmail.com>
Co-authored-by: HLasse <lasseh0310@gmail.com>
Co-authored-by: HLasse <lasseh0310@gmail.com>
Co-authored-by: HLasse <lasseh0310@gmail.com>
Co-authored-by: HLasse <lasseh0310@gmail.com>
Co-authored-by: HLasse <lasseh0310@gmail.com>
Co-authored-by: HLasse <lasseh0310@gmail.com>
Added in the newest commit as we discussed.
Added in the newest commit.
Added an issue #33
Agree. Let us do it when we have a bit more augmenters. |
No description provided.