Use environment variable JULIA_CXX_RTTI to switch RTTI on or off

[oschulz]

RTTI defaults to off, as before, but can now be switched on at any time (before using Cxx.jl) via

export JULIA_CXX_RTTI=1

without rebuilding Cxx.jl

Addresses #166. It guess it's not full solution (keep #166 open?) - but until one is found, it should make life a lot easier for people who need RTTI (like @jpata and myself). :-)

This includes #311.

[nstiurca]

+1. I am excited to try this out this week.

…

-- Nicu Știurcă (sent from my phone)

On Dec 30, 2016 4:15 PM, "Oliver Schulz" ***@***.***> wrote: RTTI defaults to off, as before, but can now be switched on at any time (before using Cxx.jl) via export JULIA_CXX_RTTI=1 *without* rebuilding Cxx.jl Addresses #166 <#166>. It guess it's not full solution (keep #166 <#166> open?) - but until one is found, it should make life a lot easier for people who need RTTI (like @jpata <https://github.com/jpata> and myself). :-) This includes #311 <#311>. ------------------------------ You can view, comment on, or merge this pull request online at: #313 Commit Summary - Update LLVM URL - Use environment variable JULIA_CXX_RTTI to switch RTTI on or off File Changes - *M* deps/BuildBootstrap.Makefile <https://github.com/Keno/Cxx.jl/pull/313/files#diff-0> (6) - *M* src/bootstrap.cpp <https://github.com/Keno/Cxx.jl/pull/313/files#diff-1> (9) Patch Links: - https://github.com/Keno/Cxx.jl/pull/313.patch - https://github.com/Keno/Cxx.jl/pull/313.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#313>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABhfE0NTU9w0ZCll17wFMeeGntFKtiAQks5rNYKIgaJpZM4LYakS> .

[jw3126]

+1 from me too!

[oschulz]

Rebased to current master.

[oschulz]

@Keno, I saw you changed settings to

Cxx->CI->getLangOpts().RTTI = 1;
Cxx->CI->getLangOpts().RTTIData = 1;

on the current master. Do you think this PR might still be useful for people who want to switch RTTI off (in that case, I'd can adapt the PR to the current master). Or should we just close this?

[Keno]

Yes, I still want to do something about this. Not quite sure which direction though. Let me do some pondering.

[oschulz]

Sure - as the default is RTTI on now, I'm happy. ;-)

[jpata]

RTTI was switched off again in the HEAD 194e99a#diff-3602d1988f104dde976bc98109e34a33R1384

It seems simply switching it on again breaks Cxx.jl

[oschulz]

RTTI was switched off again in the HEAD ... It seems simply switching it on again breaks Cxx.jl

@Keno , I guess you're currently changing some deeper things, there? I can stay with the previous version for a while, but we can get RTTI back as an option, can't we? Pretty please? ;-)

[oschulz]

This works again (I've rebased on the current master). @Keno, would you consider merging this? I know you're looking for better solution, long-term - but for now, it would make things a lot easier for people who need RTTI. Deprecating/ignoring the JULIA_CXX_RTTI env variable in the future - when it's not required anymore - shouldn't be a problem after all, right?

[oschulz]

@Keno, gentle bump.

[oschulz]

@Keno, I have a bunch of people who are interested to give Julia a shot for a new project right now, but a lot will depend on compatibility with ROOT, so we need Cxx with RTTI. It would ease things a lot if I don't have to get people to install a special branch of Cxx.jl ... would you be willing to merge this PR?

[oschulz]

Seems to work fine with Julia v0.6-RC2 as well

[Keno]

You know what, sure. I've been wanting to do better than this, but I don't have the time and as they say, the perfect is the enemy of the good.

[oschulz]

Thanks!!

[oschulz]

@Keno, when do you plan the next release of Cxx?

[vsaase]

when setting JULIA_CXX_RTTI to 1 I get the following error on using Cxx

error: run-time type information was disabled in PCH file but is currently enabled
<built-in>:1:10: fatal error: 'Cxx.h' file not found
#include "Cxx.h"

sorry, I am a Julia beginner, found the solution: rebuild the package: Pkg.build("Cxx")

[skariel]

@vsaase Doing Pkg.build("Cxx") should fix this (the PCH error thing)

[Keno]

You may have to delete the Cxx.ji file under ~/.julia somewhere (not at my computer at the moment, so can't look up the exact path). We should probably generate separate .ji files depending on the RTTI setting.

[stevengj]

With Julia 1.3 and the current Cxx.jl release, I get:

julia> ENV["JULIA_CXX_RTTI"]=1
1

julia> using Cxx
error: run-time type information was disabled in PCH file but is currently enabled
<built-in>:1:10: fatal error: '/Cxx.h' file not found
#include "/Cxx.h"

However, if I force a recompile by re-launching Julia and doing build Cxx before the above code, then it compiles.

(It's really unfortunate that Cxx.jl requires a global setting for this, which is not very composable.)

[oschulz]

Yes, Keno and me never came up with a better way to handle this. :-(