Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist with callbacks #4

Merged
merged 2 commits into from
Apr 18, 2013

Conversation

omrishuva
Copy link

No description provided.

@unorthodoxgeek
Copy link
Collaborator

I don't understand why this is needed. please write a short explanation, so I can consider this PR.
from how it seems, when the persist with callbacks flag is raised the gem is effectively disabled...
thanks dude 😄

@omrishuva
Copy link
Author

In the new design we retrive all the data from elastic search and try not do any sql query, so every time we update the db we need to update elastic search as well and the indexing is happening in an after save callback.

@unorthodoxgeek
Copy link
Collaborator

ok, I now see the error of my ways 😄

unorthodoxgeek added a commit that referenced this pull request Apr 18, 2013
@unorthodoxgeek unorthodoxgeek merged commit c479ceb into KensoDev:master Apr 18, 2013
@omrishuva
Copy link
Author

thanks for merging dude.

@unorthodoxgeek
Copy link
Collaborator

next time, please bump the version in the PR so I don't have to.
anyway, pushed version 0.1.2 to rubygems. update it in your gemfile (bundle update visit_counter)

@unorthodoxgeek
Copy link
Collaborator

oh, and I forgot. please add the new feature to the README file and open a new PR for it. thanks.

@omrishuva
Copy link
Author

ok , no problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants