feature :: 회원가입, 로그인시 계정 타입 추가 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 29, 2024 16:28
폼 가입시 type platform value 추가 카카오 가입시 type kakao value 추가 * 회원 탈퇴 코드가 중복이므로 메서드 병합 작업 진행 * 약간의 리팩터링 진행
gunsight1
added
🖥️ BackEnd
gunsight1
requested review from
linglong67,
HyunJunSon and
chan99k
as code owners
chan99k
approved these changes
Feb 29, 2024
| @@ -0,0 +1,5 @@ | |||
| package com.kernel360.member.enumset; | |||
|
|
|||
| public enum AccountType { | |||
Comment on lines
+55
to
+58
| INSERT INTO member (member_no, id, "password", email, gender, age, created_at, created_by, modified_at, modified_by, account_type) | ||
| VALUES (nextval('member_member_no_seq'::regclass), NEW.id, pgp_sym_encrypt(NEW.password::TEXT, 'changeRequired'), | ||
| pgp_sym_encrypt(NEW.email::TEXT, 'changeRequired'), NEW.gender, NEW.age, NEW.created_at, NEW.created_by, | ||
| NEW.modified_at, NEW.modified_by); | ||
| NEW.modified_at, NEW.modified_by, NEW.account_type); |
| } | ||
|
|
||
| /** | ||
| * joinMember Binding | ||
| **/ | ||
| private Member(String id, String email, String password, int gender, int age) { | ||
| private Member(String id, String email, String password, int gender, int age, String accountType) { |
There was a problem hiding this comment.
accounType 을 이용하여 관리하도록 통합된 점 확인하였습니다.
linglong67
approved these changes
Feb 29, 2024
| //Fixme :: 멤버 탈퇴시, Deleted Table을 만들고, 데이터를 백업한후, 삭제하는 방식이나, MemberTable에 삭제여부를 표시하는 방식으로 리팩토링 필요 | ||
| public void deleteMemberByToken(String accessToken) { | ||
| Member member = memberRepository.findOneById(JWT.ownerId(accessToken)); | ||
| withdrawMemberRepository.save(WithdrawMember.of(member)); //of 받는식을 변경했습니다. 이 방식으로 리팩터를 하면 코드가 깔끔하네요. |
| REVOKE INSERT, UPDATE, DELETE, TRUNCATE ON member FROM wash_admin; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
여기에 왜 이 PR이 필요했는지, PR을 통해 무엇이 바뀌는지에 대해서 설명해 주세요[정책]
[SQL]
회원테이블에 account_type이 추가되어 쿼리 파일이 수정되었습니다.
member 테이블과 뷰를 삭제하고 플라이웨이 이력을 다시 작동해야 합니다. 개발서버 회원정보는 백업해두었습니다.
폼로그인 카카오 로그인 네이버 로그인 전부 같은사람이 시도해도 다른 계정으로 취급합니다.
[코드]
회원 탈퇴 코드가 중복으로 작성되어 메서드 병합 처리를 진행 하였습니다.
탈퇴 코드 병합을 하면서 of 절 사용의 대한 리팩터링을 예시로 하나 추가하였습니다.
🔨 Modified
OF절 파라메터를 객체 통째로 보내면 코드가 더욱 간결해집니다.
계정 타입이 추가되었습니다.
🌟 More
플랫폼 회원정보에 한해서만 작동하도록 변경해야 합니다.
📋 커밋 전 체크리스트
🤟🏻 PR로 완료된 이슈
closes #217