-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability for remote keys to be rehydrated #115
Merged
KevinDockx
merged 151 commits into
KevinDockx:master
from
SeanFarrow:feature/sf/114-allow-storeKey-to-be-rehydrated
May 22, 2023
Merged
Add the ability for remote keys to be rehydrated #115
KevinDockx
merged 151 commits into
KevinDockx:master
from
SeanFarrow:feature/sf/114-allow-storeKey-to-be-rehydrated
May 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plementation and add these projects to the sln files.
…ing an ArgumentNullException is thrown when a null distributedCache parameter is passed to the constructor of the DistributedCacheValidatorValueStore class.
…en the distributedCache parameter passed in to the DistributedCacheValidatorValueStore classed constructor is null.
…nstructor that allows us to retrieve the keys from a distributed cache.
…om the DistributedCacheValidatorValueStore classes constructor when a null distributedCacheKeyRetriever is passed in.
…hrown from the DistributedCacheValidatorValueStore classes constructor when a null distributedCacheKeyRetriever is passed in.
… class is constructed when the distributedCache and distributedCacheKeyRetriever parameter passed in are not null.
…lueStore class is constructed when the distributedCache and distributedCacheKeyRetriever parameter passed in are not null.
…ValueStore interface.
…om the GetAsync method of the DistributedCacheValidatorValueStore xclass when the key passed in is null.
…ted cache passed in does not have it's GetAsync method called.
… from the GetAsync method of the DistributedCacheValidatorValueStore xclass when the key passed in is null pass.
…Async method of the DistributedCacheValidatorValueStore class when an item with the passed in key is not found in the cache.
… the GetAsync method of the DistributedCacheValidatorValueStore class when an item with the passed in key is not found in the cache.
…dCacheValidatorValueStore class returns an ETag when the passed in key is found.
…stributedCacheValidatorValueStore class returns an ETag when the passed in key is found.
…om the SetAsync method of the DistributedCacheValidatorValueStore class when the key passed in is null.
… from the SetAsync method of the DistributedCacheValidatorValueStore class when the key passed in is null pass.
…om the SetAsync method of the DistributedCacheValidatorValueStore class when the validatorValue passed in is null.
… from the SetAsync method of the DistributedCacheValidatorValueStore class when the validatorValue passed in is null pass.
…eys_When_At_Least_One_Server_Is_Available_But_No_Keys_Exist_On_Any_Of_The_Available_Servers_That_Match_The_Past_in_Value_To_Match_In_The_Database_Specified_In_The_Options_Passed_to_The_Constructor test pass.
…rs available that match the pattern passed in.
…the passed in argument pass again.
…om the AddRedisKeyRetriever method of the ServicesExtensions class when the services parameter passed in is null.
…The_Services_Parameter_Passed_In_Is_Null test pass.
SeanFarrow
force-pushed
the
feature/sf/114-allow-storeKey-to-be-rehydrated
branch
from
May 20, 2023 10:15
676366d
to
335793e
Compare
…en the redisDistributedCacheKeyRetrieverOptionsAction passed to the AddRedisKeyRetriever method of the ServicesExtensions class is null.
…The_RedisDistributedCacheKeyRetrieverOptionsAction_Parameter_Passed_In_Is_Null2 test pass.
…is key retriever are registered with the dependency injection container.
…ervices to use the host builder like every other test that validates that the required types are added to the dependency injection container.
Thank you Sean, merged! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the ability to rehydrate a key from a remote store and implements Redis as a concrete example.