Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP adding a mapper for Our Umbraco Tables property editor in V8 #529

Merged

Conversation

marcemarc
Copy link

Hi @KevinJump

I have a site that has this Our.Umbraco.Tables property editor installed on it (https://github.com/rydigital/Our.Umbraco.Tables)

Content moves fine with the default mappers, but any links to media items etc are missed as dependencies

It stores data in Json, in Cells, and the value is just the output of an RTE

  "cells": [
        [
            {
                "rowIndex": 0,
                "columnIndex": 0,
                "value": "<p><strong>Assets</strong></p>"
            },
            {
                "rowIndex": 0,
                "columnIndex": 1,
                "value": "<p><strong>4 April 2019</strong><br /><strong>£m</strong></p>"
            },

so my thinking is it is 'just' the case of calling the RTE mapper for each value, which is what I've knocked together in this PR, does that look like the right approach? or am I missing something super clever?

probably won't get chance to test it for a couple of weeks...

Content moves fine with the default mappers, but any links to media items etc are missed.
@KevinJump
Copy link
Owner

yes - i think that's it, nothing super clever, if you know its an RTE, "just" calling the mapper does everything 😄

@KevinJump KevinJump merged commit 81b6cf0 into KevinJump:v8/8.10-main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants