Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zh locale #280

Merged
merged 1 commit into from
Dec 23, 2022
Merged

add zh locale #280

merged 1 commit into from
Dec 23, 2022

Conversation

samchiu90
Copy link
Contributor

zh-Hant: Traditional Chinese
zh-Hans: Simplified Chinese

@vercel
Copy link

vercel bot commented Dec 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
material-react-table ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 23, 2022 at 3:57AM (UTC)
material-react-table-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 23, 2022 at 3:57AM (UTC)

@LvChengbin
Copy link

There a some imprecise words in simplified Chinese locale, are you guys can accept other contributions on it?

@samchiu90
Copy link
Contributor Author

samchiu90 commented Feb 16, 2023

There a some imprecise words in simplified Chinese locale, are you guys can accept other contributions on it?

I don't mind. Anyway, zh-Hant has been changed by other users already.

Some Chinese words can have different meanings in different places and scenarios,
like and , in some places, it means row while in some other places and it means column.

In my option, horizontal and vertical writing will also change the meanings of .
If the user focuses on the record, the user may call the row .
If the user focuses on the column difference between different records, the user may also call the column .

Although hk, mo, and tw use zh-Hant, and cn, my and sg use zh-Hans,
the wordings between those places are different so you may feel the wordings are imprecise.

You can also use Custom Non-Built-In Translations to override the default translation, I believe, but you can create your pull request if the words in zh-Hans are really imprecise.

@KevinVandy
Copy link
Owner

There a some imprecise words in simplified Chinese locale, are you guys can accept other contributions on it?

I don't know any of the languages myself. I just run the PRs through Google translate real quick for review, but I mostly merge anything to do with locales. Happy to fix any inaccurate translations

@LvChengbin
Copy link

Yes, using instead of 横列 is a good case which I want to point out, and there are also some other cases that I think it should be modified.
All the meanings of the words are correct, but some of them do not conform the code of simplified Chinese.

@LvChengbin
Copy link

I don't know the differences codes of simplified Chinese between cn, my and sg.
I will post a changing map before sending a pr, and you can help me to review them.

@samchiu90
Copy link
Contributor Author

@bluelovers @LvChengbin
Please check the translations in my fork.
main...samchiu90:material-react-table:2023_03_02_ZH

@KevinVandy
Copy link
Owner

@bluelovers @LvChengbin
Please check the translations in my fork.
main...samchiu90:material-react-table:2023_03_02_ZH

In case it wasn't clear, I'd love any corrections to be prd to MRT

@samchiu90
Copy link
Contributor Author

#409
@LvChengbin @bluelovers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants