Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Totp length validation #50

Merged
merged 4 commits into from
Jan 19, 2023
Merged

Totp length validation #50

merged 4 commits into from
Jan 19, 2023

Conversation

0x4f53
Copy link
Member

@0x4f53 0x4f53 commented Jan 18, 2023

♻️ Current situation

TOTPs with extremely short-length secrets (1-5 characters) are displayed inconsistently throughout the app.

💡 Proposed solution

Save a login containing a authenticator secret only if the secret length >= 6 characters. Display a discreet error in the text box otherwise.

Ideally, users copy and paste or scan a QR code to save this information, so the error accounts for an edge case where the user needs to type their secret into the authenticator secret text box.

📚 Release Notes

  • Reduced minimum authenticator secret length from 8 to 6 throughout app.
  • Added an error indicator to the authenticator text box if the secret is too short.

📝 Testing

  1. Try saving a login where the authenticator secret is in range 1..5.
  2. Tap the tick mark and observe the error icon in the authenticator secret text box.

@0x4f53 0x4f53 added the bug Something isn't working label Jan 18, 2023
@nimish-ks nimish-ks merged commit f939bc2 into v1.4.2 Jan 19, 2023
@rohan-chaturvedi rohan-chaturvedi deleted the totp_length_validation branch January 29, 2023 15:21
@rohan-chaturvedi rohan-chaturvedi mentioned this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants