Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
TOTPs with extremely short-length secrets (1-5 characters) are displayed inconsistently throughout the app.
💡 Proposed solution
Save a login containing a authenticator secret only if the secret length >= 6 characters. Display a discreet error in the text box otherwise.
Ideally, users copy and paste or scan a QR code to save this information, so the error accounts for an edge case where the user needs to type their secret into the authenticator secret text box.
📚 Release Notes
📝 Testing