Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move build logic into cmake #112

Merged
merged 26 commits into from Feb 18, 2019

Conversation

Projects
None yet
2 participants
@hendrikmuhs
Copy link
Contributor

hendrikmuhs commented Jan 30, 2019

work in progress

This change removes duplication of build logic and moves most of the logic into cmake. Cmake writes a configuration file which setup.py takes as input to know how to compile/link the library. Apart from that the cmake file has been overhauled to follow best practices.

Notes:

  • only tested on linux, likely breaks on OSX

@hendrikmuhs hendrikmuhs added the wip label Jan 30, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 3, 2019

Coverage Status

Coverage decreased (-0.3%) to 95.023% when pulling de4fc81 on hendrikmuhs:build-refactor into f1f2bbf on KeyviDev:master.

hendrikmuhs added some commits Feb 3, 2019

@hendrikmuhs

This comment has been minimized.

Copy link
Contributor Author

hendrikmuhs commented Feb 9, 2019

The decrease in coverage is due to a change in compiler flags, before: -O3 --coverage, after this PR -O0 --coverage, -O3 seems to decrease the number of relevant lines.

@hendrikmuhs hendrikmuhs removed the wip label Feb 10, 2019

@hendrikmuhs hendrikmuhs merged commit 5c84167 into KeyviDev:master Feb 18, 2019

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.3%) to 95.023%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.