Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move build logic into cmake #112

Merged
merged 26 commits into from Feb 18, 2019
Merged

Conversation

hendrikmuhs
Copy link
Contributor

work in progress

This change removes duplication of build logic and moves most of the logic into cmake. Cmake writes a configuration file which setup.py takes as input to know how to compile/link the library. Apart from that the cmake file has been overhauled to follow best practices.

Notes:

  • only tested on linux, likely breaks on OSX

@coveralls
Copy link

coveralls commented Feb 3, 2019

Coverage Status

Coverage decreased (-23.9%) to 71.482% when pulling de4fc81 on hendrikmuhs:build-refactor into f1f2bbf on KeyviDev:master.

@hendrikmuhs
Copy link
Contributor Author

The decrease in coverage is due to a change in compiler flags, before: -O3 --coverage, after this PR -O0 --coverage, -O3 seems to decrease the number of relevant lines.

@hendrikmuhs hendrikmuhs removed the wip label Feb 10, 2019
@hendrikmuhs hendrikmuhs merged commit 5c84167 into KeyviDev:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants