Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/refactor: Implement ratelimiter / queue #19

Merged
merged 4 commits into from
Feb 16, 2020
Merged

feat/refactor: Implement ratelimiter / queue #19

merged 4 commits into from
Feb 16, 2020

Conversation

Khaaz
Copy link
Owner

@Khaaz Khaaz commented Feb 16, 2020

Correct implementation of Ratelimiter and queue.
Closes #11 .

This doesn't address:

  • retry if request fails with a non ratelimit error (directly fails)
  • request caching in case of restart

responsible for ratelimit and queueing requests
- Create request
- Handle queues
- Handle errors
- Handle all requests
@Khaaz Khaaz linked an issue Feb 16, 2020 that may be closed by this pull request
@Khaaz Khaaz added bugfix enhancement New feature or request labels Feb 16, 2020
@Khaaz Khaaz merged commit d389e01 into dev Feb 16, 2020
@Khaaz Khaaz deleted the ratelimiter branch February 16, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ratelimiter and webhooks queue
1 participant