Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Multi-nerwork #22

Merged
merged 5 commits into from
Mar 16, 2020
Merged

feat: Multi-nerwork #22

merged 5 commits into from
Mar 16, 2020

Conversation

Khaaz
Copy link
Owner

@Khaaz Khaaz commented Mar 9, 2020

This PR brings support to a multi network configuration.
This PR keeps backward compatibility, which means old config design should work as expected.

Networks should be added in two places:
Appended in config:

networks: [
  {
      "name": "network1",
      "authorizationGithub": "secret",
      "authorizationGitlab": "secret"
  },
]

Appended in webhooks:

"networks": []

This allow the same webhook to be in multiple network.
This allows to have a gitlab/github secret token per network.
It will fallback to the global authorisation if not specified

Closes #10

@Khaaz Khaaz linked an issue Mar 9, 2020 that may be closed by this pull request
@Khaaz Khaaz added enhancement New feature or request v3 roadmap v3 labels Mar 9, 2020
@Khaaz Khaaz merged commit e5b59ae into dev Mar 16, 2020
@Khaaz Khaaz deleted the networks branch March 16, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v3 roadmap v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple network in the same instance
1 participant