Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setting to change default font colors #18

Open
ManjotS opened this issue Jul 27, 2018 · 4 comments
Open

add setting to change default font colors #18

ManjotS opened this issue Jul 27, 2018 · 4 comments
Milestone

Comments

@ManjotS
Copy link
Contributor

ManjotS commented Jul 27, 2018

under colors section, offer changing all the colors header1, header2, bishram, larivaar etc etc

offer a reset button for colors too (separate from global reset)

@kee23
Copy link
Collaborator

kee23 commented Jul 28, 2018

Do we want themes or a color picker? If it is a picker, then I'm assuming it overrides current font colors, regardless of light/dark theme unless we want to separate them out. Also, assuming this will change for reader view only (not list/bookmarks/settings/about).

@ManjotS
Copy link
Contributor Author

ManjotS commented Jul 28, 2018 via email

@kee23
Copy link
Collaborator

kee23 commented Jul 28, 2018

I figured it would be pick colors for:

  • Gurmukhi
  • Transliteration
  • Translation

We could add larivaar colors too. And if it's list/bookmarks, then call it menu color? The danger in adding settings if they pick a color that blends with the background, then they can't see anymore.

@ManjotS
Copy link
Contributor Author

ManjotS commented Jul 28, 2018 via email

@ManjotS ManjotS added this to the June 2020 milestone Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants